replacing .format with f-strings #31628
Conversation
pandas/tests/io/test_pickle.py
Outdated
| else: | ||
| comparator = getattr( | ||
| tm, "assert_{typ}_equal".format(typ=typ), tm.assert_almost_equal | ||
| tm, f"assert_{typ=typ}_equal", tm.assert_almost_equal |
There was a problem hiding this comment.
Thanks @drewseibert
Did you try running this test to see if it works?
pytest pandas/tests/io/test_pickle.py
(for more on testing, see Test-driven development/code writing)
There was a problem hiding this comment.
@MarcoGorelli Hi Marco, thanks for taking a look. Just gave it a run locally and I see this:
Traceback (most recent call last):
File "test_pickle.py", line 25, in
from pandas.compat import _get_lzma_file, _import_lzma, is_platform_little_endian
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pandas/init.py", line 188, in
v = get_versions()
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pandas/_version.py", line 23, in get_versions
return json.loads(version_json)
AttributeError: module 'json' has no attribute 'loads'
There was a problem hiding this comment.
I don't see any errors related to the f-strings though..
There was a problem hiding this comment.
Sorry, just ran pytest and got this instead...
../../init.py:36: in
f"C extension: {module} not built. If you want to import "
E ImportError: C extension: No module named 'pandas._libs.tslibs.conversion' not built. If you want to import pandas from the source directory, you may need to run 'python setup.py build_ext --inplace --force'
to build the C extensions first.
There was a problem hiding this comment.
For C extensions, see creating a development environment
Also, you need to run black against any Python file you've modified, see contributing to the code base
There was a problem hiding this comment.
@MarcoGorelli Thanks! Will check those out 👍
|
thanks @drewseibert |
4 participants
fixing some styling (using f-strings instead of .format)